Collect all errors from all passes, rename and document some of them #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new name gives more information about what the pass does
…umentation of related ClassSpec and EnumSpec properties
The new name gives more information about what the pass does
…ed ValueInstanceSpec property
…used only by that pass
Currently the pass DeriveValueInstanceTypes throws error if type of instance cannot be calculated, but this will change in next commit. That means that accessing `dataType` of the ValueInstanceSpec will throw an error. If such error is thrown we just cannot analyze that instance and can just ignore it (review this commit in whitespace changes ignored mode)
…d by `TypeValidator` If just return CompilationProblems from this pass, we will report some errors twice, because `TypeValidator` alro reports errors from the `TypeDetector`
This was referenced Oct 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some fields in data model filled by the compilation passes which is not obvious at all. To make this clear, I document properties which is filled by passes, document that passes and rename one of them. In the end, now all passes implements
PrepocessStepand handled uniformly. Error in one value instance no more prevents from reporting errors in other value instances or reporting warnings and type problems